[Intel-gfx] [PATCH] drm/i915: fix up locking inconsistency around gem_do_init

Chris Wilson chris at chris-wilson.co.uk
Thu Jan 26 14:42:02 CET 2012

On Thu, 26 Jan 2012 11:41:11 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> The locking in our setup and teardown paths is rather arbitrary, but
> generally we try to protect gem stuff with dev->struct_mutex. Further,
> the ums/gem ioctl to setup gem _does_ take the look. So fix up this
> benign inconsistency.

It is completely arbitrary and only exists to keep lockdep and various
BUG_ON(mutex_lock) happy. From your reading, we would have a lockdep
warning with ums/gem?

The extra little step towards consistency is likely to save a warning
later, so
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Chris Wilson, Intel Open Source Technology Centre

More information about the Intel-gfx mailing list