[Intel-gfx] [PATCH 08/10] drm/i915: introduce haswell_init_clock_gating

[Daniel Vetter]

On Tue, Jul 03, 2012 at 09:03:16PM -0300, Eugeni Dodonov wrote:
> On 07/03/12 17:24, Daniel Vetter wrote:
> > On Mon, Jul 02, 2012 at 11:51:09AM -0300, Eugeni Dodonov wrote:
> >> This is based on Ivy Bridge clock gating for now, but is subject to
> >> changes in the future.
> >>
> >> Signed-off-by: Eugeni Dodonov <eugeni.dodonov at intel.com>
> > 
> > This copy of presumeably the ivb clock gate code is missing the changes
> > introduce in:
> > 
> > commit 208482232de3590cee4757dfabe5d8cee8c6e626
> > Author: Ben Widawsky <ben at bwidawsk.net>
> > Date:   Fri May 4 18:58:59 2012 -0700
> > 
> >     drm/i915: set IDICOS to medium uncore resources
> > 
> > I guess that's not quite intentional ...
> > 
> > All the previous patches up to here are queued for -next, thanks.
> 
> I thought that this one was specific for Ivy Bridge, so I just skipped it...
> 
> I have not tried setting these settings on Haswell, so I don't know if
> it is useful here as well. I'll try later this week to see if there are
> any visible effects.

Ok, I've merged the patch and took a note that you volunteered for some
benchmarking. But the commit message really should have mentioned why this
was dropped compared to the ivb clock gating function it was copy&pasted
from. I've added a note to that effect.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48