[Intel-gfx] [PATCH] drm/i915: Make the lock for pageflips interruptible

[Daniel Vetter]

On Sun, Jul 15, 2012 at 12:06:15PM +0100, Chris Wilson wrote:
> On Wed, 23 May 2012 11:13:58 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > As we take the struct_mutex lock to access the command-stream, there is
> > a possibility that we may need to wait for a GPU hang and so should make
> > the lock both interruptible and error-checking.
> 
> Daniel?

Oops, I've totally missed this one. I think once the execbuffer fallout
for -ERESTARTSYS from intel_ring_begin has settled we should also look
into ditching the interruptible sections in our modeset code. Pageflip
should be rather simple, set_base should work, too, safe for the nasty
problem that we don't pass a sensible error code to the callers. But we
can fix that with the modeset rework. crtc mode_set is more work, but I
think when we move the fb pinning out of the ->modeset callbacks, this
should work, too.

In any case, thanks for the patch, merged to dinq.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48