[Intel-gfx] [PATCH 3/3] drm/i915: don't chnage the original mode in dp_mode_fixup

[Chris Wilson]

On Mon,  4 Jun 2012 18:39:21 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> We should only frob adjusted_mode. This is in preparation of
> a massive patch by Laurent Pinchart to make the mode argument
> const.
> 
> After the previous two prep patches the only thing left is to clean up
> things a bit. I've opted to pass in an adjust_mode param to
> dp_adjust_dithering because that way we can be sure to avoid
> duplicating this logic between mode_valid and mode_fixup - which was
> the cause behind a dp link bw calculation bug in the past.

I've found nothing else that writes to mode->clock, but still a little
uneasy over some uses. (In particular, i9xx_crtc_mode_set():
  /*  Enable pixel doubling when the dot clock is > 90% of the (display)
   * core speed. */
   if (mode->clock > dev_priv->display.get_display_clock_speed(dev) * 9 / 10)
)
However, this series addresses the only functional changes, so
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre