[Intel-gfx] [PATCH 3/3] drm/i915: don't chnage the original mode in dp_mode_fixup

[Daniel Vetter]

On Mon, Jun 04, 2012 at 11:41:50AM -0700, Jesse Barnes wrote:
> On Mon,  4 Jun 2012 18:39:21 +0200
> Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> 
> > We should only frob adjusted_mode. This is in preparation of
> > a massive patch by Laurent Pinchart to make the mode argument
> > const.
> > 
> > After the previous two prep patches the only thing left is to clean up
> > things a bit. I've opted to pass in an adjust_mode param to
> > dp_adjust_dithering because that way we can be sure to avoid
> > duplicating this logic between mode_valid and mode_fixup - which was
> > the cause behind a dp link bw calculation bug in the past.
> > 
> > Also mark the mode argument of pch_panel_fitting const.
> > 
> > v2: Split up the mode->clock => adjusted_mode->clock change,
> > as suggested by Chris Wilson.
> 
> Boo bool parameters.  A cleanup on top could split the adjust_dithering
> function so the callers would be more readable.  But that could be done
> on top or just left alone until someone gets tired of looking at the
> parameter definition.
> 
> Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>
Queued all three patches for -next, thanks for the review.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48