[Intel-gfx] [PATCH] drm/i915: Switch off FBC when disabling the primary plane when obscured

Jesse Barnes jbarnes at virtuousgeek.org
Tue Jun 12 16:28:04 CEST 2012


On Tue, 12 Jun 2012 12:46:00 +0100
Chris Wilson <chris at chris-wilson.co.uk> wrote:

> As we switch on/off the primary plane if it is completely obscured by an
> overlapping video sprite, we also nee to make sure that we update the
> FBC configuration at the same time.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=50238
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Jesse Barnes <jbarnes at virtuousgeek.org>
> ---

Yeah looks good.

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

Though now we have 3 "active" state variables for the crtc don't we?
active, enabled, and now primary_disabled?  Oh and dpms state.  I
really wish we could get rid of 2 or 3 of those...</dreaming>

Jesse



More information about the Intel-gfx mailing list