[Intel-gfx] [PATCH] drm/i915: ensure HDMI port is disabled inside set_infoframes

Eugeni Dodonov eugeni.dodonov at linux.intel.com
Tue Jun 12 17:43:42 CEST 2012


On 06/12/2012 11:36 AM, Daniel Vetter wrote:
> This function is supposed to be used at mode set time, so prevent
> against future mistakes by adding a WARN().
> 
> Based on a patch by Paulo Zanoni, with the check extracted into a
> little assert_hdmi_port_disabled helper added to make things self
> documenting and move the assert stuff out of line.
> 
> Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
> Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Apart from a typo in 'expectin' below:

Reviewed-by: Eugeni Dodonov <eugeni.dodonov at intel.com>

> +	WARN(I915_READ(intel_hdmi->sdvox_reg) & enabled_bits,
> +	     "HDMI port enabled, expectin disabled\n");
                                 ^^
Eugeni



More information about the Intel-gfx mailing list