[Intel-gfx] [PATCH 1/1] drm/i915: prevent possible pin leak on error path

Eugeni Dodonov eugeni.dodonov at intel.com
Tue Jun 19 00:03:38 CEST 2012


We should not hit this under any sane conditions, but still, this does not
looks right.

CC: Chris Wilson <chris at chris-wilson.co.uk>
CC: Daniel Vetter <daniel.vetter at ffwll.ch>
CC: stable at vger.kernel.org
Reported-by: Herton Ronaldo Krzesinski <herton.krzesinski at canonical.com>
Signed-off-by: Eugeni Dodonov <eugeni.dodonov at intel.com>
---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 7b3990e..5b50b5f 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -6178,7 +6178,7 @@ static int intel_gen7_queue_flip(struct drm_device *dev,
 	default:
 		WARN_ONCE(1, "unknown plane in flip command\n");
 		ret = -ENODEV;
-		goto err;
+		goto err_unpin;
 	}
 
 	ret = intel_ring_begin(ring, 4);
-- 
1.7.10.4




More information about the Intel-gfx mailing list