[Intel-gfx] [PATCH v4] Added support for the ns2501 DVO

[Paul Menzel]

Dear Thomas,


thanks for the iteration.

Am Mittwoch, den 20.06.2012, 20:03 +0200 schrieb Daniel Vetter:
> On Wed, Jun 20, 2012 at 07:41:51PM +0200, Thomas Richter wrote:
> > This patch adds support for the ns2501 DVO, found in some older

Please also use present tense in the commit summary.

    git commit --amend

should do the trick.

> > Fujitsu/Siemens Labtops. It is in the state of "works for me".

laptops

> > Includes now proper DPMS support. Includes switching between
> > resolutions - from 640x480 to 1024x768. Currently assumes that the
> > native display resolution is 1024x768.
> > 
> > The ns2501 seems to be rather critical - if the output PLL is not
> > running, the chip doesn't seem to be clocked and then doesn't react
> > on i2c messages. Thus, a quick'n-dirty trick ensures that the DVO
> > is active before submitting any i2c messages to it. This is
> > probably to be reviewed.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=17902
> > 
> > Signed-off-by: Thomas Richter <thor at math.tu-berlin.de>
> 
> Patch is still massively whitespace-mangling. Just export it to a file
> with
> 
> git format-patch -1 HEAD
> 
> and then attach that file, please.

Thomas, Thunderbird should allow you to select certain parts of the
message and disable automatic line wrapping for that.

[…]


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120621/3ffeaab5/attachment.sig>