[Intel-gfx] [PATCH 15/24] drm/i915: initialize DDI buffer translations

Eugeni Dodonov eugeni at dodonov.net
Tue May 1 02:27:05 CEST 2012


On Mon, Apr 30, 2012 at 21:20, Jesse Barnes <jbarnes at virtuousgeek.org>wrote:

> Ahh these are vswing and preemphasis values for the various types...
>
> Doesn't look like this goes up to the 19 dwords the docs specify?
>

The last pair is for HDMI, it is ignored for FDI/DP, so I write it along
with all others to already prepare DDI to work in any mode.


> Usually, double buffered means we need to write a trigger reg somewhere
> for the values to be latched in, or wait for vblank.  What's different
> here?
>

I'll double-check, it could be possible that they don't need to be
double-buffered. In the first series I split the double-buffering part
(with a delay) into a separate patch as it made things work more reliable
on my machine, but it got merged when I moved everything to intel_ddi.c.

FDI is not yet stable enough, so I need to find if the issues I was having
with it are due to that, or we really need the double-writing.

-- 
Eugeni Dodonov
 <http://eugeni.dodonov.net/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120430/9e0e5df1/attachment.html>


More information about the Intel-gfx mailing list