[Intel-gfx] [PATCH 08/12] drm/i915: break intel_infoframe_flags into _enable and _index

Paulo Zanoni przanoni at gmail.com
Fri May 4 16:09:54 CEST 2012


> I think the subject should be 'Break intel_infoframe_flags into _enable and
> _frequency', no?

Good catch. I can swear I fixed this before...

> And by looking at what this does, perhaps the 2nd function could be named
> intel_infoframe_freq_vsync or intel_infoframe_vsync instead?


Well, bit 18 is called "Video DIP frequency". And the frequency can be
"Once", "Every Vsync" or "At least every other VSync", so I guess
there's no need in putting the "vsync" to the name...

Thank you,
Paulo

-- 
Paulo Zanoni



More information about the Intel-gfx mailing list