[Intel-gfx] [PATCH 01/25] drm/i915: add new Haswell DIP controls registers

[Paulo Zanoni]

2012/5/9 Eugeni Dodonov <eugeni.dodonov at intel.com>:
> Haswell has different DIP control registers and offsets which we need to
> use for infoframes, which this patch adds.
>
> Note that this does not adds full DIP frames support, but only the basic
> functionality necessary for HDMI to work in early enablement.
>
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov at intel.com>
> ---

Hi

The i915_reg.h chunk seems correct, but I believe hsw_write_infoframe
is wrong. The DIP control register completely changed, and the way we
write the infoframes has also changed. Previously, we had just one
"data" register for the full 32-byte buffer and we controlled which
part of the buffer we wanted to write by the last 4 bits of the
"control" register. These last 4 bits on the control register don't
exist anymore (the whole register changed) and we have a ton of "data"
registers now. I didn't test anything I wrote here, I'm just assuming
based on the docs I have :)

For basic HDMI enablement this function is not strictly necessary, so
maybe just adding a FIXME (like you did) and returning without doing
anything would be fine. I'm going to provide a patch for this.

I checked each of the "0x" bits on the i915_reg.h chunk, so if just
committing them, you can add my Reviewed-By.

-- 
Paulo Zanoni