[Intel-gfx] [PATCH] drm/i915: Introduce for_each_ring() macro

Chris Wilson chris at chris-wilson.co.uk
Fri May 11 01:18:05 CEST 2012


On Thu, 10 May 2012 15:39:32 -0700, Ben Widawsky <ben at bwidawsk.net> wrote:
> I'm not opposed to this change, but it would have probably been better
> to not remove the BUG_ONs.

I actually removed them because in order to satisfy them we have to
initialise rings we never use (and have another patch so that we only
intialise rings once inside intel_ringbuffer.c). We were causing extra
work for ourselves for no good reason.

And we need to cull the BUG_ONs for which a WARN and recovery would
serve better.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list