[Intel-gfx] [PATCH] drm/i915: enable vdd when switching off the eDP panel

[Keith Packard]

Daniel Vetter <daniel at ffwll.ch> writes:

>> --- a/drivers/gpu/drm/i915/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/intel_dp.c
>> @@ -1154,11 +1154,10 @@ static void ironlake_edp_panel_off(struct intel_dp *intel_dp)
>>  
>>  	DRM_DEBUG_KMS("Turn eDP power off\n");
>>  
>> -	WARN(intel_dp->want_panel_vdd, "Cannot turn power off while VDD is on\n");
>> -	ironlake_panel_vdd_off_sync(intel_dp); /* finish any pending work */
>> +	WARN(!intel_dp->want_panel_vdd, "Need VDD to turn off panel\n");
>>  
>>  	pp = ironlake_get_pp_control(dev_priv);
>> -	pp &= ~(POWER_TARGET_ON | EDP_FORCE_VDD | PANEL_POWER_RESET | EDP_BLC_ENABLE);
>> +	pp &= ~(POWER_TARGET_ON | PANEL_POWER_RESET | EDP_BLC_ENABLE);

Can you explain where the panel is getting turned off here?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120521/c1f1e261/attachment.sig>