[Intel-gfx] [REVERT] - drm/i915: Removing TV Out modes

[Rodrigo Vivi]

Hi there,

Most of these modes aren't present in any of our documents and since
they aren't standards I think no sense let them there.
However I removed 480p and 576p by mistake. either looking to a closed
version of document that wont be released or thinking that they were
already contempled by one of modes that were there after the refresh
rates were fixed...

I think a patch to add these 2 missing modes better than a full
revert... I'm going to do this right now... but it is up to you revert
the old one entirely or accept this new one.

On Sat, May 19, 2012 at 3:42 PM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Sat, May 19, 2012 at 09:41:00PM +1000, Robert Lowery wrote:
>> Further to my previous post regarding getting TV Out working on recent
>> kernels, I see a recent check in to the mainline kernel source removed
>> support for 576p TV output which I use.
>>
>> Could someone please revert
>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=55a6713b3f30a5024056027e9dbf03ac8f13bfc9
>> or at least reinstate the 576p mode that I use.
>>
>> I think 480p at 59.94Hz is also a valid mode (though I don't use it) and
>> should be left in and perhaps be renamed to just 480p since there is now
>> no need to differentiate frequencies.
>>
>> Something like this?
>
> Hm, I have no idea whether we should just revert the entire commit.
> Rodrigo, your commit
>
> commit 55a6713b3f30a5024056027e9dbf03ac8f13bfc9
> Author: Rodrigo Vivi <rodrigo.vivi at gmail.com>
> Date:   Thu Dec 15 14:47:33 2011 -0200
>
>    drm/i915: Removing TV Out modes.
>
> is a bit thin on justification as to why we need that. Can you please
> explain?
>
> Thanks, Daniel
> --
> Daniel Vetter
> Mail: daniel at ffwll.ch
> Mobile: +41 (0)79 365 57 48



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br