[Intel-gfx] [PATCH] drm/i915/hdmi: Fix reg values for g4x_hdmi_connected

Daniel Vetter daniel at ffwll.ch
Fri May 25 14:33:55 CEST 2012


On Fri, May 25, 2012 at 09:25:35AM -0300, Paulo Zanoni wrote:
> 2012/5/25 Chris Wilson <chris at chris-wilson.co.uk>:
> > Paulo pointed out that gen4 re-used the SDVO registers for HDMI (the
> > separate HDMI registers where introduced with the first PCH) and so
> > g4x_hdmi_connected() never selected the right bit and always returned
> > disconnected.
> >
> > Regression in
> >
> > commit 8ec22b214d76773c9d89f4040505ce10f677ed9a
> > Author: Chris Wilson <chris at chris-wilson.co.uk>
> > Date:   Fri May 11 18:01:34 2012 +0100
> >
> >    drm/i915/hdmi: Query the live connector status bit for G4x
> >
> > Cc: Paulo Zanoni <przanoni at gmail.com>
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
> Tested-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
> 
> Tested on the gen4 machine that stopped working.
> 
> This patch adds a conflict with the patch series I sent yesterday
> (rename sdvox_reg to hdmi_reg). Please merge this one first. I'll send
> an updated version of my patch later.

Done. Thanks for patch, review&testing.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list