[Intel-gfx] [PATCH 28/43] drm: don't zero out the CRTC even if it's the same as the current one

Jesse Barnes jbarnes at virtuousgeek.org
Fri May 25 17:05:44 CEST 2012


On Fri, 25 May 2012 13:33:07 +0100
Chris Wilson <chris at chris-wilson.co.uk> wrote:

> From: Jesse Barnes <jbarnes at virtuousgeek.org>
> 
> In set_config we currently try to reset the CRTC if both the requested
> CRTC and the currently bound one are the same.  The reason for this
> appears to be lost to history (it pre-dates KMS support upstream at
> least).
> 
> Remove this restriction to allow existing configs to be simple flips
> rather than full mode sets.
> 

I'm not sure this patch is necessary anymore; I think it's wrong at any
rate.

Can you try testing without it?  My latest testing was without it iirc,
and things still worked fine.

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list