[Intel-gfx] [PATCH 00/14] More HDMI fixes V2
Paulo Zanoni
przanoni at gmail.com
Mon May 28 21:42:47 CEST 2012
From: Paulo Zanoni <paulo.r.zanoni at intel.com>
Following the comments I received and the discussions I had on IRC with Chris
and Daniel, here is the updated version. Even patch 0001 had changes, so I had
to do small adjustments on basically every single patch of the series so they
apply again.
Here is a list of changes:
0001: Add 'static' keywords (suggested by Chris)
0002: Small code change to be more defensive
0004: Add WARN to prevent future mistakes (suggested by Daniel)
0007: Small code change to be more defensive
New patches:
0012: drm/i915: clarify confusion between HDMI and SDVO registers
0013: drm/i915: add some barriers when changing DIPs
0014: drm/i915: make sure HDMI port is disabled inside set_infoframes
Patch 12 is my attempt to fix confusing names and prevent regressions like the
one that happened recently. Patch 13 was suggested by Chris and patch 14 was
suggested by Daniel.
So now the code seems pretty defensive :)
After this series is applied, I think we should go through bugzilla and start
suggesting people to test their HDMI bugs against the new tree.
Cheers,
Paulo
Paulo Zanoni (14):
drm/i915: add set_infoframes to struct intel_hdmi
drm/i915: properly alternate between DVI and HDMI
drm/i915: only set the HDMI port on the DIP once
drm/i915: enable DIP before enabling each InfoFrame
drm/i915: don't wait for vblank while writing InfoFrames
drm/i915: explicitly disable the DIPs we're not using
drm/i915: disable DIP while changing the port
drm/i915: don't write 0 to DIP control at HDMI init
drm/i915: don't set SDVO_BORDER_ENABLE when we're HDMI
drm/i915: rename sdvox_reg to hdmi_reg on HDMI context
drm/i915: remove comment about HSW HDMI DIPs
drm/i915: clarify confusion between HDMI and SDVO registers
drm/i915: add some barriers when changing DIPs
drm/i915: make sure HDMI port is disabled inside set_infoframes
drivers/gpu/drm/i915/i915_reg.h | 26 ++-
drivers/gpu/drm/i915/intel_ddi.c | 3 +-
drivers/gpu/drm/i915/intel_display.c | 38 ++--
drivers/gpu/drm/i915/intel_drv.h | 9 +-
drivers/gpu/drm/i915/intel_hdmi.c | 377 +++++++++++++++++++++++++---------
drivers/gpu/drm/i915/intel_sdvo.c | 18 +-
6 files changed, 334 insertions(+), 137 deletions(-)
--
1.7.10
More information about the Intel-gfx
mailing list