[Intel-gfx] [PATCH] drm/i915: Reset last_retired_head when resetting ring

Daniel Vetter daniel at ffwll.ch
Tue May 29 20:07:27 CEST 2012


On Mon, May 28, 2012 at 10:33:02PM +0100, Chris Wilson wrote:
> When we reset the ring control registers, including the HEAD and TAIL of
> the ring, we also need to reset associated state. In this instance, we
> were failing to reset the cached value of ring->last_retired_head and so
> upon the first request for more space following a resume would
> potentially (depending on a narrow race window) believe that the HEAD had
> advanced much further than reality.
> 
> This is a regression from:
> 
> commit a71d8d94525e8fd855c0466fb586ae1cb008f3a2
> Author: Chris Wilson <chris at chris-wilson.co.uk>
> Date:   Wed Feb 15 11:25:36 2012 +0000
> 
>     drm/i915: Record the tail at each request and use it to estimate the head
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: stable at vger.kernel.org # 3.4

Applied to -fixes, thanks for spotting this.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list