[Intel-gfx] [PATCH 1/3] drm/i915: Wait for pending flips in intel_pipe_set_base()

[Chris Wilson]

On Thu,  1 Nov 2012 20:06:00 +0200, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> intel_pipe_set_base() never actually waited for any pending page flips
> on the CRTC. It looks like it tried to, by calling intel_finish_fb() on
> the current front buffer. But the pending flips were actually tracked
> in the BO of the previous front buffer, so the call to intel_finish_fb()
> never did anything useful.
> 
> Now even the pending_flip counter is gone, so we should just
> use intel_crtc_wait_for_pending_flips(), but since we're already holding
> struct_mutex when we would call that function, we need another version
> of it, that itself doesn't lock struct_mutex.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Your earlier point was that intel_finish_fb() is being called in the wrong
place, if you fix that first you should not need the major surgery.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre