[Intel-gfx] [PATCH 1/2] drm/i915/sdvo: clean up connectors on intel_sdvo_init() failures

[Chris Wilson]

On Mon, 12 Nov 2012 18:31:35 +0200, Jani Nikula <jani.nikula at intel.com> wrote:
> Any failures in intel_sdvo_init() after the intel_sdvo_setup_output() call
> left behind ghost connectors, attached (with a dangling pointer) to the
> sdvo that has been cleaned up and freed. Properly destroy any connectors
> attached to the encoder.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=46381
> CC: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> 
> ---
> 
> This is *completely* untested, and I don't really know if the connector
> loop is okay or naïve in some way... Please review and test carefully. CC
> Chris in case this addresses his SDVO EDID failures too.

Sadly not. The issue in question, for readers at home, is that after

commit 9cd300e038d492af4990b04e127e0bd2df64b1ca
Author: Jani Nikula <jani.nikula at intel.com>
Date:   Fri Oct 19 14:51:52 2012 +0300

    drm/i915: Move cached EDID to intel_connector
    
    Move the cached EDID from intel_dp and intel_lvds_connector to
    intel_connector. Unify cached EDID handling for LVDS and eDP, in
    preparation for adding more generic EDID caching later.

I lose the EDID on a SDVO-LVDS device (an ilk dual LVDS and SDVO-LVDS
Libretto W105).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre