[Intel-gfx] [PATCH] drm/i915/i2c: Track users of GMBUS force-bit

Jani Nikula jani.nikula at intel.com
Tue Nov 13 15:39:43 CET 2012


On Sat, 10 Nov 2012, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> @@ -583,7 +583,10 @@ void intel_gmbus_force_bit(struct i2c_adapter *adapter, bool force_bit)
>  {
>  	struct intel_gmbus *bus = to_intel_gmbus(adapter);
>  
> -	bus->force_bit = force_bit;
> +	bus->force_bit += force_bit ? 1 : -1;
> +	DRM_DEBUG_KMS("%sabling bit-banging on %s. force bit now %d\n",
> +		      force_bit ? "dis" : "en", adapter->name,
> +		      bus->force_bit);

Reading a dmesg from Chris, I noticed force_bit ? "dis" : "en" is
backwards.

BR,
Jani.




More information about the Intel-gfx mailing list