[Intel-gfx] [PATCH] drm/i915: Remove bogus test for a present execbuffer

[Eric Anholt]

Chris Wilson <chris at chris-wilson.co.uk> writes:

> The intention of checking obj->gtt_offset!=0 is to verify that the
> target object was listed in the execbuffer and had been bound into the
> GTT. This is guarranteed by the earlier rearrangement to split the
> execbuffer operation into reserve and relocation phases and then
> verified by the check that the target handle had been processed during
> the reservation phase.
>
> However, the actual checking of obj->gtt_offset==0 is bogus as we can
> indeed reference an object at offset 0. For instance, the framebuffer
> installed by the BIOS often resides at offset 0 - causing EINVAL as we
> legimately try to render using the stolen fb.

We've never triggered this check in practice, as far as I know, so I'm
happy to see it go.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20121119/3b9de120/attachment.sig>