[Intel-gfx] [PATCH 1/2] drm/i915: Defer assignment of obj->gtt_space until after all possible mallocs

Daniel Vetter daniel at ffwll.ch
Wed Nov 21 15:19:16 CET 2012


On Wed, Nov 21, 2012 at 01:46:29PM +0000, Chris Wilson wrote:
> On Wed, 21 Nov 2012 14:27:06 +0100, Daniel Vetter <daniel at ffwll.ch> wrote:
> > Ok, I now see what's going on. Can't we do the bind together with the
> > mappable bind, i.e.
> > 
> > if (!has_global_mapping && (map_and_fenceable || !aliasing_ppgtt))
> >         i915_gem_gtt_bind_object()
> 
> You can indeed do it that way, it just took up too many lines... Imo, I
> think we want to eventually push the i915_gem_gtt_bind_object() to the
> callers. (You'll see why later if we ever get the current 3.7 regression
> resolved.)

Ok, count me convinced, both patches merged.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list