[Intel-gfx] [PATCH 4/4] drm/i915: only call intel_prepare_ddi if HAS_DDI

Chris Wilson chris at chris-wilson.co.uk
Fri Nov 23 18:54:34 CET 2012


On Fri, 23 Nov 2012 15:30:40 -0200, Paulo Zanoni <przanoni at gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
> 
> In other words, move the check from inside the function to outside it.

Don't agree with this last step. You can make the function tidier with
an early return, but it is paramount that the high level sequence inside
intel_modeset_init_hw() be clear and comprehendable.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list