[Intel-gfx] [PATCH 00/17] lvds/dp/watermark refactorings

Paulo Zanoni przanoni at gmail.com
Tue Nov 27 22:14:01 CET 2012


2012/11/26 Daniel Vetter <daniel.vetter at ffwll.ch>:
> Hi all,
>
> Second round for my lvds/dp/watermark refactorings, which are a prep work for
> the next step in reworking the modeset code (which is currently brewing at a
> rather slow rate in my modeset-rework branch). Safe where I've disagreed this
> should incorporate all review feedback from Paulo Zanoni.
>
> Comments&flames highly welcome.

I just briefly tested patches 1 to 7 on an ILK laptop with a dual-link
LVDS. I just booted, changed modes, checked dmesg and then turned the
machine off. So "Briefly-tested-by: Paulo Zanoni
<paulo.r.zanonI at intel.com>". All the 7 patches have "Reviewed-by"
stamps now, so If you don't plan to apply any of the bikesheds, you
could just merge them and then we can focus on only discussing patches
8 to 17.

>
> Thanks, Daniel
>
> Daniel Vetter (17):
>   drm/i915: add encoder->pre_pll_enable callback
>   drm/i915: replace ad-hoc dual-link lvds checks
>   drm/i915: move is_dual_link_lvds to intel_lvds.c
>   drm/i915: track is_dual_link in intel_lvds
>   drm/i915: add intel_lvds->reg
>   drm/i915: move intel_update_lvds to intel_lvds->pre_pll_enable
>   drm/i915: enable intel_lvds->pre_pll_enable for ilk+, too
>   drm/i915: rip out pre-DDI stuff from haswell_crtc_mode_set
>   drm/i915: move set_pll_edp to intel_dp.c
>   drm/i915: rip out pre-production ilk cpu edp w/a
>   drm/i915: use wait_for_vblank instead of msleep(17)
>   drm/i915: WARN on !crtc in intel_dp_link_down
>   drm/i915: drop unnecessary clearing of pch dp transcoder timings
>   drm/i915: extract common link_m_n helpers
>   drm/i915: don't call update_watermark in crtc_mode_set
>   drm/i915: don't call update_watermarks from haswell enable/disable
>     code
>   drm/i915: rip out update_linetime_wm abstraction
>
>  drivers/gpu/drm/i915/i915_drv.h      |  16 +-
>  drivers/gpu/drm/i915/intel_display.c | 430 +++++------------------------------
>  drivers/gpu/drm/i915/intel_dp.c      |  87 ++++---
>  drivers/gpu/drm/i915/intel_drv.h     |   4 +-
>  drivers/gpu/drm/i915/intel_lvds.c    | 160 +++++++++++--
>  drivers/gpu/drm/i915/intel_pm.c      |  37 ---
>  6 files changed, 258 insertions(+), 476 deletions(-)
>
> --
> 1.7.11.7
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni



More information about the Intel-gfx mailing list