[Intel-gfx] [PATCH 6/9] drm/i915: implement WaDisablePSDDualDispatchEnable on IVB and VLV

[Jesse Barnes]

On Mon, 1 Oct 2012 17:52:21 +0100
"Lespiau, Damien" <damien.lespiau at intel.com> wrote:

> On Tue, Sep 25, 2012 at 9:51 AM, Daniel Vetter <daniel at ffwll.ch> wrote:
> > On Wed, Sep 19, 2012 at 01:29:00PM -0700, Jesse Barnes wrote:
> >> Workaround for dual port PS dispatch on GT1.
> >>
> >> Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> >> +     /* WaDisablePSDDualDispatchEnable */
> >> +     if (dev->pci_device == 0x0156 ||
> >> +         dev->pci_device == 0x0152)
> >
> > Can we please have a comment here explaining which pci ids we're matching
> > here? Just in case we add yet another variant sometime. Or just plainly
> > use IS_MOBILE, which seems to match here ...
> > -Daniel
> 
> This looks like testing if we're running on an IVB GT1 device (and
> then we're missing 0x015a?). The address of the register is different
> on GT1 and GT2 devices.
> 
Yeah I have an updated version that uses IS_MOBILE since I think that
matches the IDs we want.

Jesse