[Intel-gfx] [PATCH] drm/i915: Try harder to complete DP training pattern 1

Daniel Vetter daniel at ffwll.ch
Wed Oct 3 16:00:07 CEST 2012


On Wed, Oct 03, 2012 at 02:50:19PM +0100, Lespiau, Damien wrote:
> On Wed, Sep 26, 2012 at 4:48 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > In commit cdb0e95bf571dccc1f75fef9bdad21b167ef0b37
> > Author: Keith Packard <keithp at keithp.com>
> > Date:   Tue Nov 1 20:00:06 2011 -0700
> >
> >     drm/i915: Try harder during dp pattern 1 link training
> >
> > extra passes were made to retry the same voltage and then retry a full
> > clock reset. However, as coverity pointed out, we never tried the full
> > clock reset as we broke out of the loop early.
> 
> Took me a while to wrap my head around this one, no wonder only
> Coverity pointed out. I managed to convince myself the fix is correct
> though.
> 
> Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>

Picked up for -fixes, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list