[Intel-gfx] [PATCH] drm/i915: Set guardband clipping workaround bit in the right register.

[Paul Menzel]

Dear Kenneth,


thanks for the patch.


Am Freitag, den 05.10.2012, 17:46 -0700 schrieb Kenneth Graunke:
> Commit bf97b276ca04

Could you please paste the date, author and commit summary of this
commit too? At least I cannot memorize hashes that well and having the
summary pasted would give me enough information most of the time about
the other commit. ;-)

> accidentally set bit 5 in 3D_CHICKEN, which has
> nothing to do with clipping.  This patch changes it to be set in
> 3D_CHICKEN3, where it belongs.
> 
> The game "Dante" demonstrates random clipping issues when guardband
> clipping is enabled and bit 5 of 3D_CHICKEN3 isn't set.  So the
> workaround actually is necessary.
> 
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: Oliver McFadden <oliver.mcfadden at linux.intel.com>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  drivers/gpu/drm/i915/i915_reg.h | 2 +-
>  drivers/gpu/drm/i915/intel_pm.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

[…]

Acked-by: Paul Menzel <paulepanter at users.sourceforge.net>


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20121006/13319643/attachment.sig>