[Intel-gfx] [PATCH] drm/i915: Set guardband clipping workaround bit in the right register.

Mika Kuoppala mika.kuoppala at linux.intel.com
Tue Oct 9 09:43:10 CEST 2012


On Sun,  7 Oct 2012 08:51:07 -0700, Kenneth Graunke <kenneth at whitecape.org> wrote:
> A previous patch, namely:
> 
> commit bf97b276ca04cee9ab65ffd378fa8e6aedd71ff6
> Author: Daniel Vetter <daniel.vetter at ffwll.ch>
> Date:   Wed Apr 11 20:42:41 2012 +0200
> 
>     drm/i915: implement w/a for incorrect guarband clipping
> 
> accidentally set bit 5 in 3D_CHICKEN, which has nothing to do with
> clipping.  This patch changes it to be set in 3D_CHICKEN3, where it
> belongs.
> 
> The game "Dante" demonstrates random clipping issues when guardband
> clipping is enabled and bit 5 of 3D_CHICKEN3 isn't set.  So the
> workaround is actually necessary.
> 
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: Oliver McFadden <oliver.mcfadden at linux.intel.com>
> Acked-by: Paul Menzel <paulepanter at users.sourceforge.net>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

Reviewed-by: Mika Kuoppala <mika.kuoppala at intel.com>



More information about the Intel-gfx mailing list