[Intel-gfx] [PATCH] drm/i915: fixup i915_gem_object_get_page inline helper

[Chris Wilson]

On Tue,  9 Oct 2012 22:50:48 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> The obj->pages to obj->pages->sgl rework introduced this helper, but
> it doesn't actually work for n >= SG_MAX_SINGLE_ALLOC.
> 
> For simplicity (and since right now I seem to be too stupid to see
> the bug), let's just grab the right page with a for_each_sg loop.
> 
> This is exercised by the improved hangman tests and the gem_exec_big
> test in i-g-t.
> 
> v2: Compared to v1, don't try to be clever since I seemingly only
> manage to prove that I'm not clever.

Only I expect that loop to show up on profiles even higher than the
sg_next() from pwrite. :|

I expect it to have a measureable impact upon relocation throughput,
so I should measure it...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre