[Intel-gfx] [PATCH] drm/i915: fixup i915_gem_object_get_page inline helper

Daniel Vetter daniel at ffwll.ch
Wed Oct 10 13:38:07 CEST 2012


On Wed, Oct 10, 2012 at 12:11:52PM +0100, Chris Wilson wrote:
> Note that just because we have n == MAX elements left, does not imply
> that there are only MAX elements left in the scatterlist and so we may
> not be on the last chain, and the nth element may in fact be a chain ptr.
> 
> This is exercised by the improved hangman tests and the gem_exec_big
> test in i-g-t.
> 
> This regression has been introduced in
> 
> commit 9da3da660d8c19a54f6e93361d147509be3fff84
> Author: Chris Wilson <chris at chris-wilson.co.uk>
> Date:   Fri Jun 1 15:20:22 2012 +0100
> 
>    drm/i915: Replace the array of pages with a scatterlist
> 
> v2: KISS, replace the direct lookup with a for_each_sg() [danvet]
> v3: Try to be clever again.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

I've merged this one and dropped v2 from -fixes, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list