[Intel-gfx] [PATCH 2/3] drm/i915: fixup the plane->pipe fixup code

Chris Wilson chris at chris-wilson.co.uk
Thu Oct 11 10:03:21 CEST 2012


On Wed, 10 Oct 2012 23:14:00 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> We need to check whether the _other plane is on our pipe, not whether
> our plane is on the other pipe. Otherwise if not both pipes/planes are
> active, we won't properly clean up the mess and set up our desired
> plane->pipe mapping.
> 
> v2: Fixup the logic, I've totally fumbled it. Noticed by Chris Wilson.
> 
> v3: I've checked Bspec, and the flexible plane->pipe mapping is a
> gen2/3 feature, so test for that instead of PCH_SPLIT
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51265
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=49838
> Tested-by: Dave Airlie <airlied at gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

With these patches applied my 855gm is still in good working order (the
best it has been). Though I'm still spammed by modeset_check failing in
every possible way!

Tested-by: Chris Wilson <chris at chris-wilson.co.uk> #855gm
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list