[Intel-gfx] [PATCH 2/3] drm/i915: Workaround to bump rc6 voltage to 450

[Daniel Vetter]

On Sat, Sep 29, 2012 at 01:07:35PM -0700, Ben Widawsky wrote:
> On Fri, 28 Sep 2012 10:13:26 +1000
> Dave Airlie <airlied at gmail.com> wrote:
> 
> > On Fri, Sep 28, 2012 at 4:05 AM, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> > > On Wed, 26 Sep 2012 10:34:01 -0700
> > > Ben Widawsky <ben at bwidawsk.net> wrote:
> > >
> > >> BIOS should be setting the minimum voltage for rc6 to be 450mV. Old or
> > >> buggy BIOSen may not be doing this, so we correct it for them. Ideally
> > >> customers should update the BIOS as only it would know the optimal
> > >> values for the platform, so we leave that fact as a DRM_ERROR for the
> > >> user to see.
> > >>
> > >> Unfortunately this isn't fixing any of the issues it was targeted to
> > >> fix, but it is documented that we must do it.
> > 
> > Yeah drop the DRM_ERROR, it should be DRM_INFO at worst, and
> > non-existant at best.
> > 
> > Who gives a shit if you have to upgrade your BIOS, lots of vendors
> > won't provide updates and I don't see Intel doing anything to solve
> > that.
> > 
> > Dave.
> 
> 
> I dunno, messing with voltages seems pretty scary to me. I'd really like
> a loud warning when the driver does it. I perhaps agree that telling the
> user to update the BIOS isn't a message we want to classify as an ERROR.
> I think at least a DRM_DEBUG_DRIVER, but I give Daniel permission to
> change it as he sees fit assuming the rest of the patch is fine for
> everyone.

Merged these 2 patches, too, with the error tuned down to a debug message.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch