[Intel-gfx] [PATCH 07/18] drm/i915: convert DDI_FUNC_CTL to transcoder

[Paulo Zanoni]

Hi

2012/10/24 Lespiau, Damien <damien.lespiau at intel.com>:
> On Tue, Oct 23, 2012 at 9:29 PM, Paulo Zanoni <przanoni at gmail.com> wrote:
>> +#define TRANS_DDI_FUNC_CTL_A           0x60400
>> +#define TRANS_DDI_FUNC_CTL_B           0x61400
>> +#define TRANS_DDI_FUNC_CTL_C           0x62400
>> +#define TRANS_DDI_FUNC_CTL_EDP         0x6F400
>> +#define DDI_FUNC_CTL(tran) _TRANSCODER(tran, TRANS_DDI_FUNC_CTL_A, \
>> +                                            TRANS_DDI_FUNC_CTL_B)
>
> I was also thinking that it'd be nice to know what we need to give to
> that macro at a glimpse where we call it, so maybe name it
> TRANS_DDI_FUNC_CTL(trans)?

I agree with you. In fact even on the old code PIPE_DDI_FUNC_CTL would
be better. It looks like I got used to it :)

The only problem here is that I'll also have to resend patches 8 and
13 since they use the renamed register.
>
> --
> Damien



-- 
Paulo Zanoni