[Intel-gfx] [PATCH 09/36] drm/i915: don't rely on DDI_BUF_CTL previous values
Paulo Zanoni
przanoni at gmail.com
Wed Oct 31 21:12:28 CET 2012
From: Paulo Zanoni <paulo.r.zanoni at intel.com>
... inside hsw_fdi_link_train. Just set the bits we want, everything
else is zero.
While at it, also POSTING_READ the register before waiting.
Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index e903502..0cb6441 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -188,13 +188,11 @@ void hsw_fdi_link_train(struct drm_crtc *crtc)
DP_TP_CTL_ENABLE);
/* Configure and enable DDI_BUF_CTL for DDI E with next voltage */
- temp = I915_READ(DDI_BUF_CTL(PORT_E));
- temp = (temp & ~DDI_BUF_EMP_MASK);
I915_WRITE(DDI_BUF_CTL(PORT_E),
- temp |
- DDI_BUF_CTL_ENABLE |
- ((intel_crtc->fdi_lanes - 1) << 1) |
- hsw_ddi_buf_ctl_values[i]);
+ DDI_BUF_CTL_ENABLE |
+ ((intel_crtc->fdi_lanes - 1) << 1) |
+ hsw_ddi_buf_ctl_values[i]);
+ POSTING_READ(DDI_BUF_CTL(PORT_E));
udelay(600);
--
1.7.11.4
More information about the Intel-gfx
mailing list