[Intel-gfx] [PATCH 20/36] drm/i915: don't call ironlake_enable_pch_pll on lpt_pch_enable
Paulo Zanoni
przanoni at gmail.com
Wed Oct 31 21:12:39 CET 2012
From: Paulo Zanoni <paulo.r.zanoni at intel.com>
This is just wrong. The lpt_program_iclkip should disable the PCH
pixel clocks (and yes, we plan to rename it later).
Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 39f5bd1..8761023 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3142,15 +3142,6 @@ static void lpt_pch_enable(struct drm_crtc *crtc)
assert_transcoder_disabled(dev_priv, pipe);
- /* XXX: pch pll's can be enabled any time before we enable the PCH
- * transcoder, and we actually should do this to not upset any PCH
- * transcoder that already use the clock when we share it.
- *
- * Note that enable_pch_pll tries to do the right thing, but get_pch_pll
- * unconditionally resets the pll - we need that to have the right LVDS
- * enable sequence. */
- ironlake_enable_pch_pll(intel_crtc);
-
lpt_program_iclkip(crtc);
/* set transcoder timing, panel must allow it */
--
1.7.11.4
More information about the Intel-gfx
mailing list