[Intel-gfx] [PATCH xf86-video 2/2] dri: fix leakage of FB when closing the screen
Chris Wilson
chris at chris-wilson.co.uk
Wed Sep 5 12:19:30 CEST 2012
On Fri, 31 Aug 2012 14:31:51 +0300, Imre Deak <imre.deak at intel.com> wrote:
> Calling drmModeRmFB is only allowed in DRM master mode. Since leaving
> the VT also drops master mode we need to remove the FB before calling
> I830LeaveVT.
>
> This is only a real leak in case of a server reset, otherwise the server
> process will exit anyway and the kernel will clean up the FB.
Your reasoning is sound and the new location of leave_vt did not scare
me...
Thanks, pushed. I'm not too concerned over simply warning about an
unfixable leak along the anomalous path, though the debug spew in the
kernel for this error is not as obvious as I'd like.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx
mailing list