[Intel-gfx] [PATCH 31/58] drm/i915: check connector hw/sw state
Jesse Barnes
jbarnes at virtuousgeek.org
Wed Sep 5 18:26:24 CEST 2012
On Sun, 19 Aug 2012 21:12:48 +0200
Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> Atm we can only check the connector state after a dpms call - while
> doing modeset with the copy&pasted crtc helper code things are too
> ill-defined for proper checking. But the idea is very much to call
> this check from the modeset code, too.
>
> v2: Fix dpms check and don't presume that if the hw isn't on that it
> must not be linked up with an encoder (it could simply be switched off
> with the dpms state).
Nice. Only comment is that we may want to call it assert_state() to
match our other assertions. But no biggie.
Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
More information about the Intel-gfx
mailing list