[Intel-gfx] [PATCH 35/58] drm/i915: introduce struct intel_set_config

Daniel Vetter daniel.vetter at ffwll.ch
Wed Sep 5 21:27:13 CEST 2012


On Wed, Sep 5, 2012 at 6:34 PM, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
>         if (!config)
>                 return;
> ?
>
> My eyes always hurt a little when I see if blocks that take up the
> whole function. :)  Just a nit pick though.

Yeah, looks better. Bikeshed applied locally since it resulted in some
conflicts later on.
-Daniel
-- 
Daniel Vetter
daniel.vetter at ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list