[Intel-gfx] [PATCH] drm/i915: Wait for all pending operations to the fb before disabling the pipe

[Daniel Vetter]

On Wed, Sep 12, 2012 at 09:03:03AM -0700, Jonathan Nieder wrote:
> Timo Aaltonen wrote:
> 
> > Well, these are usually hard to verify fixed. The commit is mentioned on
> > fdo bugs 45413 and 48838, should fix some GPU hangs.
> 
> The stable kernel rules are very clear about this:
> 
>  - It must be obviously correct and tested.
> 
> Please ensure the backport gets tested on a machine that was
> affected by the problem.  That doesn't mean we need 100%
> confidence that the fix worked, but if I understand you
> correctly it is possible that nobody tested the backport on
> real hardware at all.
> 
> An ack from someone on the i915 team would be welcome as well.

It's the right thing. The comment about "hough we still have a window for
userspace to submit a broken command buffer during the modeset" just
re-stresses that client can still kill the gpu. But with this fix here
userspace has at least a chance to get it right, whereas before it just
fell over sometimes.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch