[Intel-gfx] [PATCH] drm/i915: Reduce a pin-leak BUG into a WARN

Chris Wilson chris at chris-wilson.co.uk
Mon Sep 17 09:59:40 CEST 2012


On Mon, 17 Sep 2012 09:48:24 +0200, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Sat, Sep 15, 2012 at 09:41:57AM +0100, Chris Wilson wrote:
> > Pin-leaks persist and we get the perennial bug reports of machine
> > lockups to the BUG_ON(pin_count==MAX). If we instead loudly report that
> > the object cannot be pinned at that time it should prevent the driver from
> > locking up, and hopefully restore a semblance of working whilst still
> > leaving us a OOPS to debug.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Picked up for -fixes, thanks for the patch. wrt pin leaks, I think all the
> ones we still have are worker thread starvations, combined with irqs
> firing too fast. /should/ be fixable ...

Right, the latest are in association with pageflipping so that's a
plausible cause. Otoh, we also appear to have a multiple unpin somewhere
in the reset code - which might very well be related. Hmm.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list