[Intel-gfx] [PATCH] drm/i915: Flush the pending flips on the CRTC before modification

Chris Wilson chris at chris-wilson.co.uk
Fri Sep 28 14:04:03 CEST 2012


On Fri, 28 Sep 2012 08:37:20 +0200, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Thu, Sep 27, 2012 at 09:25:58PM +0100, Chris Wilson wrote:
> > This was meant to be the purpose of the
> > intel_crtc_wait_for_pending_flips() function which is called whilst
> > preparing the CRTC for a modeset or before disabling. However, as Ville
> > Syrjala pointed out, we set the pending flip notification on the old
> > framebuffer that is no longer attached to the CRTC by the time we come
> > to flush the pending operations. Instead, we can simply wait on the
> > pending unpin work to be finished on this CRTC, knowning that the
> > hardware has therefore finished modifying the registers, before proceeding
> > with our direct access.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Can I haz testcase plz?

Fixes i-g-t/flip_test
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list