[Intel-gfx] [PATCH 07/11] drm/i915: fix VLV limits and m/n/p calculations v2

Daniel Vetter daniel at ffwll.ch
Tue Apr 2 20:59:22 CEST 2013


On Thu, Mar 28, 2013 at 09:55:43AM -0700, Jesse Barnes wrote:
> From: Pallavi G <pallavi.g at intel.com>
> 
> For high res modes m n p calculation is fixed for VLV platform.
> 
> v2: use 64 bit types and math (Ville)
> 
> Signed-off-by: Pallavi G <pallavi.g at intel.com>
> Signed-off-by: Vijay Purushothaman <vijay.a.purushothaman at intel.com>
> Signed-off-by: Yogesh M <yogesh.mohan.marimuthu at intel.com>
> Signed-off-by: Gajanan Bhat <gajanan.bhat at intel.com>

I'd love to have a fixed dp pll values look-up table like we have for
other platforms, so that we use _exactly_ what the hw guys recommend.

Also: Did I mention that I've failed to count the indent level of the vlv
pll computation function? And iirc that's been promised to eventually get
fixed ...

I'll random-punt on this one here for now.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list