[Intel-gfx] [PATCH 3/3] drm/i915: Don't use the HDMI port color range bit on Valleyview

[Daniel Vetter]

On Wed, Apr 03, 2013 at 12:33:31PM +0300, Jani Nikula wrote:
> On Tue, 02 Apr 2013, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> >
> > VLV docs still list the the color range selection bit for the HDMI
> > ports, but for DP ports it has been repurposed.
> >
> > I have no idea whether the HDMI color range selection bit still works
> > on VLV, but since we now have to use the PIPECONF color range bit for
> > DP, we might as well do the same for HDMI.
> 
> I don't have any additional information on this. The patch does what it
> says above, so for that:
> 
> Reviewed-by: Jani Nikula <jani.nikula at intel.com>

Patches 2/3 also queued for -next, thanks for the patch.
-Daniel
> 
> 
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> > index b206a0d..ee4a8da 100644
> > --- a/drivers/gpu/drm/i915/intel_hdmi.c
> > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> > @@ -602,7 +602,7 @@ static void intel_hdmi_mode_set(struct drm_encoder *encoder,
> >  	u32 hdmi_val;
> >  
> >  	hdmi_val = SDVO_ENCODING_HDMI;
> > -	if (!HAS_PCH_SPLIT(dev))
> > +	if (!HAS_PCH_SPLIT(dev) && !IS_VALLEYVIEW(dev))
> >  		hdmi_val |= intel_hdmi->color_range;
> >  	if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
> >  		hdmi_val |= SDVO_VSYNC_ACTIVE_HIGH;
> > -- 
> > 1.8.1.5
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch