[Intel-gfx] [PATCH 12/13] drm/i915: fix DP get_hw_state return value

Daniel Vetter daniel at ffwll.ch
Thu Apr 4 01:18:39 CEST 2013


On Thu, Apr 04, 2013 at 01:15:28AM +0200, Daniel Vetter wrote:
> On Tue, Apr 02, 2013 at 08:11:05PM +0200, Daniel Vetter wrote:
> > On Tue, Apr 02, 2013 at 10:03:56AM -0700, Jesse Barnes wrote:
> > > If we couldn't find a pipe we shouldn't return true.  This might be even
> > > better as a WARN though, since it should be impossible to have the port
> > > enabled without a pipe selected.
> > > 
> > > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> > 
> > These two fixes are merged for -next, thanks.
> 
> Actually this one here is broken, so I've had to revert it.

I'm also a bit unsure about the DDI one, since if we ever have a port
enabled with a bogus pipe link, we probably still want to shut down the
port. At least that part is pretty important to not end up with a black
screen in a lot of cases, atm Egbert Eich is debugging such a case for
sdvo ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list