[Intel-gfx] [PATCH] drm/i915: s/mdelay/msleep/

Chris Wilson chris at chris-wilson.co.uk
Mon Apr 8 12:03:41 CEST 2013


On Sun, Apr 07, 2013 at 11:13:03AM +0200, Daniel Vetter wrote:
> The first in wait_pipe_off is really just a delay loop to wait for the
> scanline counter to settle (which takes about a frame worth of time).
> So also shrink it a bit.
> 
> The other is in the ilk dprs code. If we need _exactly_ an 1ms wait in
> there, that's already not guaranteed with the current code (since
> especially at start-up we're likely to get scheduled away in between).
> So replace those, too.
> 
> Noticed while trying to understand why we've again broken the panel
> fitter.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

The only reason the mdelay(5) persisted for so long was that we were
being lazy and not verifying that path could not be called from atomic
context.

The others I just credit Jesse for.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list