[Intel-gfx] commit drm/i915: disable shared panel fitter for pipe breaks resolution switching

[Daniel Vetter]

On Tue, Apr 9, 2013 at 7:59 PM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Tue, Apr 9, 2013 at 7:51 PM, Hans de Bruin <jmdebruin at xmsnet.nl> wrote:
>>>          /* pipesrc and dspsize control the size that is scaled from,
>>>           * which should always be the user's requested size.
>>>           */
>>>          I915_WRITE(DSPSIZE(plane),
>>>                     ((mode->vdisplay - 1) << 16) |
>>>                     (mode->hdisplay - 1));
>>>          I915_WRITE(DSPPOS(plane), 0);
>>>
>>>          I915_WRITE(PIPECONF(pipe), pipeconf);
>>>          POSTING_READ(PIPECONF(pipe));
>>>          //intel_enable_pipe(dev_priv, pipe, false);
>>>
>>>          intel_wait_for_vblank(dev, pipe);
>>>
>>>          I915_WRITE(DSPCNTR(plane), dspcntr);
>>>          POSTING_READ(DSPCNTR(plane));
>>> ...
>>>
>>> The screen still does not scale.
>>>
>>>
>>> By the way, I have had this problem before:
>>> https://bugzilla.kernel.org/show_bug.cgi?id=43071
>>
>>
>> sorry my mistake that one did scale, but just was not alligned properly.
>
> Now I'm confused, please clarify: Did the patch help a bit? Can you
> pls describe more precisely what "not aligned properly" means? Have
> you checked whether changing the scaling mode xrandr property helps?

Ok, I guess that was just a comment to say that the current bug isn't
quite a match with the old bug. Anyway, I think I've tracked down this
regression here, but since I couldn't reproduce it, can you please
test the patch at:

https://patchwork.kernel.org/patch/2428981/

Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch