[Intel-gfx] [PATCH 1/1] drm/i915: shorten i915_next_seqno debugfs output

[Kees Cook]

On Thu, Apr 11, 2013 at 6:22 AM, Mika Kuoppala
<mika.kuoppala at linux.intel.com> wrote:
> commit 647416f9eefe7699754b01b9fc82758fde83248c
> Author: Kees Cook <keescook at chromium.org>
> Date:   Sun Mar 10 14:10:06 2013 -0700
>
>     drm/i915: use simple attribute in debugfs routines
>
> made i915_next_seqno debugfs entry to crop it's output
> if returned value was large enough. Using simple_attr
> will limit the output to 24 bytes. Fix this by returning
> only the value and nothing else.
>
> Cc: Kees Cook <keescook at chromium.org>
> Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>

Oh! Thanks for catching that. What a weird limitation.

What about max freq, min freq, and wedged? Do those run the risk of
truncation too?

-Kees

> ---
>  drivers/gpu/drm/i915/i915_debugfs.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index be88532..afe9421 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -901,7 +901,7 @@ i915_next_seqno_set(void *data, u64 val)
>
>  DEFINE_SIMPLE_ATTRIBUTE(i915_next_seqno_fops,
>                         i915_next_seqno_get, i915_next_seqno_set,
> -                       "next_seqno :  0x%llx\n");
> +                       "0x%llx\n");
>
>  static int i915_rstdby_delays(struct seq_file *m, void *unused)
>  {
> --
> 1.7.9.5
>



--
Kees Cook
Chrome OS Security