[Intel-gfx] [PATCH 2/3] drm/i915: don't intel_crt_init on any ULT machines

[Paulo Zanoni]

Hi

2013/4/16 Daniel Vetter <daniel at ffwll.ch>:
> On Mon, Apr 15, 2013 at 09:45:00PM +0100, Chris Wilson wrote:
>> On Fri, Apr 12, 2013 at 06:16:53PM -0300, Paulo Zanoni wrote:
>> > From: Paulo Zanoni <paulo.r.zanoni at intel.com>
>> >
>> > We may have DDI_BUF_CTL(PORT_A) configured with 2 lanes and still not
>> > have CRT, so just check for !IS_ULT. This problem happened on a real
>> > machine and resulted in a very ugly dmesg.
>> >
>> > Cc: stable at vger.kernel.org
>> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
>>
>> This doesn't apply to dinq. The approach I'd favour is to have a
>> intel_info.has_crt similar to the other feature flags.
>
> I'm ok with piling checks on top here for now, I guess we should
> reconsider once the next hw platforms shows up around the corner ...

We can always apply Chris's suggestion as a follow-up patch.

>
> All patches merged to dinq, thanks.

I thought patch 2 would go to -fixes. We need it even for older Kernels.

Thanks for the reviews,
Paulo

> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch



--
Paulo Zanoni